How to update a field in an after_save logic hook?

Hello all,

I have created a custom field to hold an autoincrement value for each record in the module. This works ok.

I would like to use this number as a part of the name of the record. So, I have created a logic_hook based on the after_save event.

Unfortunately, it seems that $bean data is not available when after_save-ing.

It I test the logic_hook in before_save event, the code works ok and Name field is properly updated. However I can't use the code in before_save because it only would work when editing records not when creating them, because the logic hook would be fired before setting the autoincrement value.

Any ideas?

Here is my code, so simple. I'm on SugarCRM CE 6.5.11.

class my_class{
  public function my_function(&$bean, $event, $arguments){
    $bean->name = $bean->my_autoincrement_field_c;
  }
}

0 Jason Eggers over 9 years ago

In a case like this I'd go straight to the database and do an update query. Either that or in your after_save call do a $bean->save(). There is some built-in protection against nested logic hooks, but it would be wise to also set a static var to ensure that your hook only runs once if you call ->save() again.
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 Kedar Gawande over 9 years ago in reply to Jason Eggers
Jaume,

To add to eggsurplus's notes, in your after_save hook, you just need to :

$bean->db->query(" UPDATE {$bean->table_name} SET name='{$bean->my_autoincrement_field_c}' WHERE id='{$bean->id}' ");

This will update the name field in the bean's table with the value from the 'my_autoincrement_field_c'.

But be careful whether you need the name to be set on EVERY save of the record as doing this without any checks/conditions will overwrite the "name" field if any other logic or users have updated it to something else.

ie you might want to only update the name once and not everytime and/or based on certain checks/conditions.

eg set it to the my_autoincrement_field_c value only if the name is empty

class my_class{
public function my_function(&$bean, $event, $arguments){ if(empty($bean->name)){
$bean->db->query(" UPDATE {$bean->table_name} SET name='{$bean->my_autoincrement_field_c}' WHERE id='{$bean->id}' "); }
}
}
Cheers
Kedar.
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 Francesca Shiekh over 9 years ago in reply to Kedar Gawande

Why do an after save? That will change the name and save again which will call the after save again...
Why not do a before_save instead? You should be able to just set the $bean->name as you have above:
$bean->name = $bean->my_autoincrement_field_c;

My general approach is that if you are changing fields of the bean you are saving then use a before_save, if you are changing another bean then you can use an after_save.

HTH
FrancescaS
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 Kedar Gawande over 9 years ago in reply to Francesca Shiekh

FrancescaS, I agree that before_save is better but in this case, its an autoincrement field which doesnt get a value until the record is created in the DB, hence the need for an after_save

Cheers
Kedar
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 Romney Lai over 9 years ago in reply to Francesca Shiekh

I think of this differently - why don't you make the name field the auto increment field instead?
If this is for display only, then wouldn't it be easier to change the display using customCode?
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 Jaume Albaigès over 9 years ago in reply to Francesca Shiekh

FrancescaS, thank you very much for your answer. As SugarNinja already pointed, I can't use before_save because before record creation the autoincremented value is not set. Otherwise I agree that before_save is better for field modification inside the bean.
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 Jaume Albaigès over 9 years ago in reply to Romney Lai

rlai, thank you very much for your answer. I am not sure that you can change the data type of a field after its creation. On the other hand, I don't think that you can make a text field to be autoincremented by the database, I believe it might be an int type field to be autoincremented. In my case, it is possible that the name field would contain something else concatenated with that code, so I would prefer to keep a separated code field.
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 Jaume Albaigès over 9 years ago in reply to Jason Eggers

Thank you very much, eggsurplus. Will try this idea.
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 Jaume Albaigès over 9 years ago in reply to Kedar Gawande

Thank you very much for your help, SugarNinja. I'm going to try your code. Thank you for your advices too. Both name and autoinc fields are set to readonly in editview and quickcreateview so it seems there is no risk on updating the name on each save, but it wouldn't be unuseful to take some cautions, as you suggested.
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 Jaume Albaigès over 9 years ago in reply to Kedar Gawande

Hello again, I already tried your code but it seems it won't work because $bean->my_autoincrement_field_c is set to NULL. It seems that $bean properties are not updated after the record is created. Sounds it reasonable?
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel